Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: trigger raftBeforeFollowerSend failpoint in linearizability test #15268

Merged

Conversation

lavacat
Copy link

@lavacat lavacat commented Feb 9, 2023

raftBeforeFollowerSend can only be triggered on Follower and won't work on 1 node cluster. Had to split RandomFailpoint into RandomOneNodeClusterFailpoint and RandomMultiNodeClusterFailpoint

Signed-off-by: Bogdan Kanivets bkanivets@apple.com

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

raftBeforeFollowerSend can only be triggered on Follower and won't work on 1 node cluster.
Had to split RandomFailpoint into RandomOneNodeClusterFailpoint and RandomMultiNodeClusterFailpoint

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
@lavacat
Copy link
Author

lavacat commented Feb 9, 2023

This is the last failpoint from #14726 cc @serathius

@serathius
Copy link
Member

This is good enough as temporary workaround, however would like to avoid having to manually maintain per cluster config list of failpoints. Rather failpoint.Available should be made aware of cluster config so it will return false when it cannot be used on a specific cluster config.

@serathius serathius merged commit d0575e4 into etcd-io:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants