raft: Really avoid scanning raft log in becomeLeader #9887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I meant to do this in etcd-io#9073, but sent the PR before it was finished. The last log index is known directly; there is no need to fetch any entries here.
|
lgtm |
bdarnell
added a commit
to cockroachdb/vendored
that referenced
this pull request
Jun 27, 2018
bdarnell
added a commit
to bdarnell/cockroach
that referenced
this pull request
Jun 27, 2018
Release note (bug fix): Alleviate a scenario in which a large number of uncommitted Raft commands could cause memory pressure at startup time.
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Jun 28, 2018
27024: release-2.0: cherry-pick etcd-io/etcd#9887 r=tschottdorf a=bdarnell This is the release-2.0 counterpart to #27009. Release note (bug fix): Alleviate a scenario in which a large number of uncommitted Raft commands could cause memory pressure at startup time. Co-authored-by: Ben Darnell <ben@cockroachlabs.com>
tbg
added a commit
to cockroachdb/vendored
that referenced
this pull request
Jul 19, 2018
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Jul 19, 2018
Pick up etcd-io/etcd#9887, which avoids pulling the uncommitted portion of the Raft log into memory. Release note (bug fix): Alleviate a scenario in which a large number of uncommitted Raft commands could cause memory pressure at startup time.
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Jul 19, 2018
27009: vendor: bump etcd/raft to pick up memory usage fix r=bdarnell a=tschottdorf Pick up etcd-io/etcd#9887, which avoids pulling the uncommitted portion of the Raft log into memory. Release note (bug fix): Alleviate a scenario in which a large number of uncommitted Raft commands could cause memory pressure at startup time. Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Hoverbear
pushed a commit
to tikv/raft-rs
that referenced
this pull request
Jul 31, 2018
Hoverbear
pushed a commit
to tikv/raft-rs
that referenced
this pull request
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I meant to do this in #9073, but sent the PR before it was finished.
The last log index is known directly; there is no need to fetch any
entries here.