Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-add-mugloo-base-metall2 #921

Merged

Conversation

raahulrathore
Copy link
Contributor

@raahulrathore raahulrathore commented Sep 3, 2024

Description

A cross chain token for my upcoming project for OpStack.

  • Already listed for Optimism.

L1 Contract:
Ethereum: 0x8e3c68a9c10d3bf2aaf14f2e569a8223f21bf2b6

Metall2:0xf1F9Ccc7638F124c3d9354Be0edE2ACb5F0A15Bc

going with Base for now as per below thread, will raise a new one for Metall2

added mugloo for base and metall2
@raahulrathore raahulrathore requested review from wbnns and a team as code owners September 3, 2024 10:52
@nitaliano
Copy link
Collaborator

nitaliano commented Sep 3, 2024

@raahulrathore thanks for the PR! metal isn't supported yet in this repo if you would like to add it as part of your PR you can follow the steps that this PR did to add a new chain https://github.com/ethereum-optimism/ethereum-optimism.github.io/pull/906/files?file-filters%5B%5D=.md&file-filters%5B%5D=.ts&show-viewed-files=true

@raahulrathore
Copy link
Contributor Author

thanks for the update @nitaliano!
I'd then remove the metal from this PR and will get in touch with them for the changes,
so for now, will be going with Base only.

@raahulrathore
Copy link
Contributor Author

@nitaliano updated the PR,
only going with Base as of now, will add metal in another PR.
Thanks!

@mergify mergify bot merged commit 69b9689 into ethereum-optimism:master Sep 4, 2024
5 checks passed
wbnns added a commit that referenced this pull request Sep 5, 2024
@wbnns
Copy link
Collaborator

wbnns commented Sep 5, 2024

Hi @raahulrathore, thanks for building on Base! Apologies, it looks like there is an issue with your PR in that the source code on the token contract you deployed on Base isn't verified.

Can you please verify it and follow-up here? We may need you to open a new PR, sorry about that.

mergify bot pushed a commit that referenced this pull request Sep 5, 2024
@raahulrathore
Copy link
Contributor Author

Hi @wbnns, sure
lemme go through the comments on #922 and raise a new one as requested.

@raahulrathore raahulrathore mentioned this pull request Sep 10, 2024
@raahulrathore
Copy link
Contributor Author

Hi @wbnns @nitaliano
Here is the follow up PR #925 catering the comments

@squdgy
Copy link
Contributor

squdgy commented Sep 19, 2024

@raahulrathore thanks for the PR! metal isn't supported yet in this repo if you would like to add it as part of your PR you can follow the steps that this PR did to add a new chain https://github.com/ethereum-optimism/ethereum-optimism.github.io/pull/906/files?file-filters%5B%5D=.md&file-filters%5B%5D=.ts&show-viewed-files=true

@nitaliano I'm from the Metal L2 team, and I put up this PR to add our chain (and testnet): #932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants