Update EIP-4762: unconditionnal account write during contract init #8867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
|
🛑 Auto merge failed. Please see logs for more details, and report this issue at the |
eth-bot
changed the title
eth-bot
approved these changes
Sep 6, 2024
auto-merge was automatically disabled
September 6, 2024 13:04
Pull request was converted to draft
jsign
reviewed
Sep 6, 2024
| @@ -132,11 +132,6 @@ When a contract creation is initialized, process these write events: | |||
|
|
|||
| ``` | |||
| (contract_address, 0, BASIC_DATA_LEAF_KEY) | |||
| ``` | |||
There was a problem hiding this comment.
I wonder if "creation is initialized" is well defined. As in: after collision check.
There was a problem hiding this comment.
thinking the same thing, also we should clarify the TouchAndChargeContractCreateCheck change that was done in geth. It is not obvious and may result in a few errors in implementation?
|
lgtm |
|
lgtm too - we were already doing this in a way |
holiman
pushed a commit
to ethereum/go-ethereum
that referenced
this pull request
Sep 13, 2024
Implementation of [this EIP-4762 update](ethereum/EIPs#8867). --------- Signed-off-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: Tanishq Jasoria <jasoriatanishq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current state of the spec, there are a few instances where the basic leaf can be created but not the code hash leaf.
This unconditionally write-touch all leaves upon contract initialization, as this will result in an account no matter what happens. The only difference is that the value of the code hash will either be the hash of the contract code, or the empty hash, but that does not impact the gas costs.