miner: suspend miner if node is syncing #27218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
force-pushed
the
prevent-miner
branch
2 times, most recently
from
1f117be
to
51fd1f8
Compare
holiman
approved these changes
May 8, 2023
rjl493456442
force-pushed
the
prevent-miner
branch
from
51fd1f8
to
5d46764
Compare
|
LGTM, let's merge after the release |
rjl493456442
force-pushed
the
prevent-miner
branch
from
5d46764
to
ce7a347
Compare
rjl493456442
force-pushed
the
prevent-miner
branch
from
ce7a347
to
7088257
Compare
meowsbits
added a commit
to etclabscore/ethereum.go-ethereum
that referenced
this pull request
Aug 31, 2023
This reverts commit d496188. Conflicts: miner/worker.go miner/worker_test.go
10 tasks
This was referenced Oct 30, 2023
github-merge-queue bot
pushed a commit
to dogechain-lab/dbsc
that referenced
this pull request
Nov 10, 2023
### Description - backporting ethereum/go-ethereum#27218 - remove `commitWork` delay, delay exist the `Seal` stage, `commitWork` delay causing timing confusion. - change `Seal` stage delay, reduce chain reorganization --------- Signed-off-by: 0xcb9ff9 <0xcb9ff9@proton.me>
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
Drop the notions of uncles, and disables activities while syncing - Disable activities (e.g. generate pending state) while node is syncing, - Disable empty block submission (but empty block is still kept for payload building), - Drop uncle notion since (ethash is already deprecated)
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit f768ce5.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit f768ce5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things listed below