signer/core/apitypes: support fixed size arrays for EIP-712 typed data #30175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdymalla
changed the title
resolves: https://github.com/ethereum/go-ethereum/issues/30183
mdymalla
changed the title
resolves: https://github.com/ethereum/go-ethereum/issues/30183
Magken91
approved these changes
Jul 21, 2024
Magken91
approved these changes
Jul 21, 2024
holiman
changed the title
holiman
changed the title
mask-pp
pushed a commit
to mask-pp/go-ethereum
that referenced
this pull request
Aug 30, 2024
ethereum#30175) When attempting to hash a typed data struct that includes a type reference with a fixed-size array, the validation process fails. According to EIP-712, arrays can be either fixed-size or dynamic, denoted by `Type[n]` or `Type[]` respectively, although it appears this currently isn't supported. This change modifies the validation logic to accommodate types containing fixed-size arrays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #30183When attempting to hash a typed data struct that includes a type reference with a fixed-size array, the validation process fails. According to EIP-712, arrays can be either fixed-size or dynamic, denoted by
Type[n]orType[]respectively, although it appears this currently isn't supported.This PR introduces a change to the validation logic to accommodate types containing fixed-size arrays.