Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/tracing: add verkle gas change reasons to changelog #30444

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Sep 16, 2024

Add changes from #30409 and #29338 to changelog.

Btw @gballet seems like GasChangeWitnessContractCreation is unused.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.14.9 milestone Sep 17, 2024
core/tracing/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
@gballet
Copy link
Member

gballet commented Sep 17, 2024

Btw @gballet seems like GasChangeWitnessContractCreation is unused.

It's going to be, it's just a matter of merging more verkle code.

@s1na s1na merged commit 8032b63 into ethereum:master Sep 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants