CLI and JS admin changes #773

zelig · 2015-04-22T02:55:27Z

js console: rename debug.block to debug.processBlock
js console: move backtrace under debug
js console: add cors domain optional argument to startRpc
cli: clean up flag descriptions, usage docs, account list uses primary - fixes geth show "primary" account #732
cli: fatal error if rpc could not be started
backend: start miner in its go routine (no wait to generate DAG)
cli: fatal error if no etherbase for mining

Note major change of behaviour:

geth -datadir /tmp/zelig  -port 30300 -rpc -rpcaddr 'foo'
Welcome to the FRONTIER
Fatal: Error starting RPC: listen tcp 127.0.53.53:8545: bind: can't assign requested address

geth -datadir /tmp/zelig  -port 30300 -mine
Welcome to the FRONTIER
Fatal: Cannot start mining without etherbase address: no accounts found

closes #721

obscuren · 2015-04-22T09:53:09Z

cmd/geth/admin.go

 	config := rpc.RpcConfig{
 		ListenAddress: addr,
 		ListenPort:    uint(port),
-		// CorsDomain:    ctx.GlobalString(RPCCORSDomainFlag.Name),


This should still be honoured in case the corsDomain was left blank.

thx i think this is a mistake

zelig · 2015-04-22T14:00:17Z

fixed and rebased

…nder debug

…y and indexes, add help line to account subcnd usage

…to value set on command line with `-corsDomain`

CLI and JS admin changes

* cmd/swarm: minor cli flag text adjustments * cmd/swarm, swarm/storage, swarm: fix mingw on windows test issues * cmd/swarm: support for smoke tests on the production swarm cluster * cmd/swarm/swarm-smoke: simplify cluster logic as per suggestion * changed colour of landing page * landing page reacts to enter keypress * swarm/api/http: sticky footer for swarm landing page using flex * swarm/api/http: sticky footer for error pages and fix for multiple choices * swarm: propagate ctx to internal apis (ethereum#754) * swarm/simnet: add basic node/service functions * swarm/netsim: add buckets for global state and kademlia health check * swarm/netsim: Use sync.Map as bucket and provide cleanup function for ServiceFunc * swarm, swarm/netsim: adjust SwarmNetworkTest * swarm/netsim: fix tests * swarm: added visualization option to sim net redesign * swarm/netsim: support multiple services per node * swarm/netsim: remove redundant return statement * swarm/netsim: add comments * swarm: shutdown HTTP in Simulation.Close * swarm: sim HTTP server timeout * swarm/netsim: add more simulation methods and peer events examples * swarm/netsim: add WaitKademlia example * swarm/netsim: fix comments * swarm/netsim: terminate peer events goroutines on simulation done * swarm, swarm/netsim: naming updates * swarm/netsim: return not healthy kademlias on WaitTillHealthy * swarm: fix WaitTillHealthy call in testSwarmNetwork * swarm/netsim: allow bucket to have any type for a key * swarm: Added snapshots to new netsim * swarm/netsim: add more tests for bucket * swarm/netsim: move http related things into separate files * swarm/netsim: add AddNodeWithService option * swarm/netsim: add more tests and Start* methods * swarm/netsim: add peer events and kademlia tests * swarm/netsim: fix some tests flakiness * swarm/netsim: improve random nodes selection, fix TestStartStop* tests * swarm/netsim: remove time measurement from TestClose to avoid flakiness * swarm/netsim: builder pattern for netsim HTTP server (ethereum#773) * swarm/netsim: add connect related tests * swarm/netsim: add comment for TestPeerEvents * swarm: rename netsim package to network/simulation

* cmd/swarm: minor cli flag text adjustments * cmd/swarm, swarm/storage, swarm: fix mingw on windows test issues * cmd/swarm: support for smoke tests on the production swarm cluster * cmd/swarm/swarm-smoke: simplify cluster logic as per suggestion * changed colour of landing page * landing page reacts to enter keypress * swarm/api/http: sticky footer for swarm landing page using flex * swarm/api/http: sticky footer for error pages and fix for multiple choices * swarm: propagate ctx to internal apis (ethereum#754) * swarm/simnet: add basic node/service functions * swarm/netsim: add buckets for global state and kademlia health check * swarm/netsim: Use sync.Map as bucket and provide cleanup function for... * swarm, swarm/netsim: adjust SwarmNetworkTest * swarm/netsim: fix tests * swarm: added visualization option to sim net redesign * swarm/netsim: support multiple services per node * swarm/netsim: remove redundant return statement * swarm/netsim: add comments * swarm: shutdown HTTP in Simulation.Close * swarm: sim HTTP server timeout * swarm/netsim: add more simulation methods and peer events examples * swarm/netsim: add WaitKademlia example * swarm/netsim: fix comments * swarm/netsim: terminate peer events goroutines on simulation done * swarm, swarm/netsim: naming updates * swarm/netsim: return not healthy kademlias on WaitTillHealthy * swarm: fix WaitTillHealthy call in testSwarmNetwork * swarm/netsim: allow bucket to have any type for a key * swarm: Added snapshots to new netsim * swarm/netsim: add more tests for bucket * swarm/netsim: move http related things into separate files * swarm/netsim: add AddNodeWithService option * swarm/netsim: add more tests and Start* methods * swarm/netsim: add peer events and kademlia tests * swarm/netsim: fix some tests flakiness * swarm/netsim: improve random nodes selection, fix TestStartStop* tests * swarm/netsim: remove time measurement from TestClose to avoid flakiness * swarm/netsim: builder pattern for netsim HTTP server (ethereum#773) * swarm/netsim: add connect related tests * swarm/netsim: add comment for TestPeerEvents * swarm: rename netsim package to network/simulation

zelig added in progress type:feature labels Apr 22, 2015

zelig added this to the Frontier milestone Apr 22, 2015

zelig self-assigned this Apr 22, 2015

zelig added ready and removed in progress labels Apr 22, 2015

obscuren reviewed Apr 22, 2015
View reviewed changes

obscuren added the review label Apr 22, 2015

zelig force-pushed the frontier/cli branch from 437bdc3 to 260af08 Compare April 22, 2015 13:59

zelig added 8 commits April 24, 2015 12:45

cmd/admin: rename debug.block to debug.processBlock; move backtrace u…

a3fb419

…nder debug

js console: add cors domain optional argument to startRpc

22450c0

cli: clean up flag descriptions, usage docs, account list uses primar…

7b2f25b

…y and indexes, add help line to account subcnd usage

cli: fatal error if rpc could not be started

6512b23

backend: start miner in its go routine (no wait to generate DAG)

be84395

cli: fatal error if no etherbase for mining

1b7c017

cli/js console: if corsDomain is not given to startRpc, we fall back …

6b1b5a4

…to value set on command line with `-corsDomain`

cli: correct bootnodes flag usage help line

c5e9a0a

zelig force-pushed the frontier/cli branch from 260af08 to c5e9a0a Compare April 24, 2015 11:48

obscuren added a commit that referenced this pull request Apr 24, 2015

Merge pull request #773 from ethersphere/frontier/cli

168ff36

CLI and JS admin changes

obscuren merged commit 168ff36 into ethereum:develop Apr 24, 2015

obscuren removed ready labels Apr 24, 2015

zelig deleted the frontier/cli branch December 8, 2015 20:51

tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this pull request Jan 20, 2022

Add garbage collection for RoundStateDB (ethereum#773)

5b910ec

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLI and JS admin changes #773

CLI and JS admin changes #773

zelig commented Apr 22, 2015

obscuren Apr 22, 2015

zelig Apr 22, 2015

zelig commented Apr 22, 2015

CLI and JS admin changes #773

CLI and JS admin changes #773

Conversation

zelig commented Apr 22, 2015

obscuren Apr 22, 2015

Choose a reason for hiding this comment

zelig Apr 22, 2015

Choose a reason for hiding this comment

zelig commented Apr 22, 2015