-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
@frozeman, thanks! @luclu and @evertonfraga, please review this. |
From the code standpoint: 👍. Looked at every non-merge commit and they all seem fine. I'll test against the ETH fixes, maybe monday morning. |
@@ -28,6 +28,7 @@ process.on('loaded',function () { | |||
|
|||
|
|||
window.mist = mist(); | |||
window.mistMode = remote.getGlobal('mode'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the mistMode shouldn't be exposed to dapps in browser.js.
We also don't want to require remote her, for security reasons.
The issue should be fixed in the wallet.js
ce00e89
to
67957b3
Compare
position: 1, | ||
permissions: { | ||
admin: true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Security issues were tested. |
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Improves security in preloaders.
Fixes:
Moves mist API to preloader include.
Fixes callback issue in Mist API.