Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few instances of British spelling in introduction-to-smart-contracts.rst #15481

Closed
wants to merge 1 commit into from

Conversation

panditdhamdhere
Copy link

There are two spelling mistakes "initialize" and "behavior" corrected.

There are two spelling mistakes "initialize" and "behavior" corrected.
Copy link

github-actions bot commented Oct 6, 2024

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@nikola-matic
Copy link
Collaborator

There are two spelling mistakes "initialize" and "behavior" corrected.

Closing this since it's just a UK vs US English difference, and we have a ton of them anyway, so setting a precedent of fixing these one or two words at a time is a bad idea overall.

@panditdhamdhere
Copy link
Author

I think it's good idea to use US or UK, Throughout the docs there are some words used in US then same words on same page used in UK.

Thank you @nikola-matic

@nikola-matic
Copy link
Collaborator

I think it's good idea to use US or UK, Throughout the docs there are some words used in US then same words on same page used in UK.

Thank you @nikola-matic

You are absolutely right, but this is a recurring theme not only in our docs, but in the code base as well, and accepting PRs that change a couple of words at a time would set a bad precedent, where we could potentially be overwhelmed by the amount of PRs doing just that.

@cameel cameel changed the title Update introduction-to-smart-contracts.rst Fix a few instances of British spelling in introduction-to-smart-contracts.rst Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants