Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vm nightly tests #3285

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Fix vm nightly tests #3285

merged 2 commits into from
Mar 4, 2024

Conversation

jochem-brouwer
Copy link
Member

@jochem-brouwer jochem-brouwer commented Feb 15, 2024

Closes #3278

TODO:

The root build problem is: DefinitelyTyped/DefinitelyTyped#68655

This is because lru-cache got this commit: isaacs/node-lru-cache@1fb1167 which got introduced in v10.2.0. The problem is that the map problem of @types/node is wrong (see the discussion linked above). Have pinned lru-cache to the previous version which works.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.88%. Comparing base (f502494) to head (f717024).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.34% <ø> (ø)
blockchain 91.61% <ø> (ø)
client 84.77% <ø> (ø)
common 98.43% <ø> (+0.18%) ⬆️
devp2p 82.12% <ø> (ø)
ethash ∅ <ø> (∅)
evm 74.03% <ø> (-0.22%) ⬇️
genesis 99.98% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 77.00% <ø> (ø)
trie 89.55% <ø> (+0.27%) ⬆️
tx 95.45% <ø> (ø)
util 89.13% <ø> (ø)
vm 79.84% <ø> (+0.22%) ⬆️
wallet 88.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jochem-brouwer jochem-brouwer merged commit 41a7468 into master Mar 4, 2024
46 checks passed
@holgerd77 holgerd77 deleted the fix-vm-nightly-tests branch March 6, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VM Nightly Tests fail
2 participants