Client: Refactor Engine API #3291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
acolytec3
reviewed
Feb 21, 2024
| @@ -0,0 +1,159 @@ | |||
| import { Block } from '@ethereumjs/block' | |||
There was a problem hiding this comment.
Can we rename this file to something like blockchainHelpers or something? generic seems to communicate to me that this is something to with type generics (aka something like function<T>(arg1, arg2))
acolytec3
reviewed
Feb 21, 2024
| @@ -0,0 +1,14 @@ | |||
| import { bytesToHex } from '@ethereumjs/util' | |||
There was a problem hiding this comment.
Any objection to including under getPayload.ts since it and the getPayload methods are logically connected and this doesn't have many lines of code to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Engine API has grown like crazy over the last months and years and our single
engine.tsfile doesn't hold all the code any more.This is a much needed basic structural refactoring, putting things into its own files, adding (some) additional code docs and generally making the overloaded
engine.tsfile leaner and better readable again.Still WIP, will push some additional clean-ups, likely ready for review at the end of the day though.