Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tree key computation to verkle and simplify #3420

Merged
merged 10 commits into from
May 14, 2024

Conversation

acolytec3
Copy link
Contributor

This migrates the getTreeKey* methods (and related constants) from statemanager to verkle where they are more properly housed.

  • Replaces getTreeKeyFor* methods with a single getTreeKey that accepts a leafType as a second input and returns the correct tree key corresponding to the value type

gabrocheleau
gabrocheleau previously approved these changes May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 83.12%. Comparing base (d24ca11) to head (2a2c698).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 80.78% <ø> (?)
blockchain 90.97% <ø> (ø)
common 94.29% <ø> (+<0.01%) ⬆️
devp2p 81.85% <ø> (?)
evm 73.76% <100.00%> (?)
genesis 99.98% <ø> (?)
statemanager 74.56% <58.33%> (+0.25%) ⬆️
trie 59.69% <ø> (?)
util 81.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@acolytec3 acolytec3 merged commit f82af3b into master May 14, 2024
34 of 36 checks passed
@acolytec3 acolytec3 deleted the move-tree-keys-to-verkle branch May 14, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants