Remove top level await #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roninjin10 Does this address your concerns from #10? I've re-written the exports along the lines of what we did for |
acolytec3
force-pushed
the
remove-top-level-await
branch
from
dd60bb8
to
3adcb71
Compare
|
This is perfect! Thanks for this. Seeing the related ethereumjs pr and the breaking change here doesn't look too bad |
holgerd77
previously approved these changes
Mar 7, 2024
|
Hmm, something strange going on here when I try to merge. 🤔 Also, advice from https://stackoverflow.com/questions/53712930/how-to-fix-this-in-git-this-branch-is-out-of-date-with-the-base-branch is not working. Will eventually try to re-submit the PR. |
|
Replaced by #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10 and replaces the current setup with an async function that initializes the WASM and returns the three EC functions as properties of an object.