Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add generate_db_auth_token #3

Merged
merged 1 commit into from
Dec 5, 2017

Conversation

kyleaa
Copy link
Collaborator

@kyleaa kyleaa commented Dec 5, 2017

Addresses #2

I'm not sure there's a good way to unit test this, short of just verifying the token starts with the hostname. The actual signing is tested in ex_aws.

@benwilson512 I'm not sure how the releases work in the split-repo world. This depends on the commit that was just merged into ex_aws, so as long as ex_aws_rds doesn't get a release until after that is released, it should be good to go.

@benwilson512
Copy link
Contributor

@kyleaa yeah so for the release process what I'd like to do is push a patch release for ExAws itself, and then set you up with hex ownership so that you can push this package to hex.

@kyleaa
Copy link
Collaborator Author

kyleaa commented Dec 5, 2017

It looks like this repo might not have a maintainer based on #1 - I'm happy to volunteer if that's the case.

@benwilson512 benwilson512 merged commit cd81c49 into ex-aws:master Dec 5, 2017
@benwilson512
Copy link
Contributor

Added you. ExAws 2.0.2 is out. If you send me your email address somehow I can add you as a hex maintainer

@kyleaa kyleaa deleted the generate-auth-token branch December 6, 2017 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants