Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support Node.js@20 in the CI #5429

Closed

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Feb 2, 2024

Main Changes

Add support for Node 20 in the CI (9015d2a) and appveyor (6dc18f9)

Note: Node 20.11.1 is last version available

Changelog

@UlisesGascon UlisesGascon marked this pull request as ready for review February 2, 2024 15:28
Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget about appveyor :)

Copy link
Member

@aravindvnair99 aravindvnair99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning to minor would be better than pinning to patch as then we wouldn't have to keep incrementing each time and can test for the latest release within that minor.

appveyor.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@dougwilson
Copy link
Contributor

LGTM. As soon as the patch gets released within the next couple days I'll make the minor branch and land this there per usual.

Copy link
Member

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants