-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): updates python support #308
Merged
arajkumar
merged 2 commits into
fabric8-analytics:master
from
invincibleJai:fix-py-sup-ls
Aug 8, 2019
Merged
feat(python): updates python support #308
arajkumar
merged 2 commits into
fabric8-analytics:master
from
invincibleJai:fix-py-sup-ls
Aug 8, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
invincibleJai
commented
May 15, 2019
- updates python support
sivaavkd
reviewed
May 15, 2019
sivaavkd
reviewed
May 20, 2019
[test] |
1 similar comment
[test] |
invincibleJai
force-pushed
the
fix-py-sup-ls
branch
from
May 20, 2019 09:16
c6614a1
to
4dbd7aa
Compare
invincibleJai
changed the title
[WIP]feat(python): updates python support
[Don't Merge]feat(python): updates python support
May 20, 2019
LGTM |
invincibleJai
force-pushed
the
fix-py-sup-ls
branch
from
July 30, 2019 20:45
db96f30
to
0fef4d0
Compare
invincibleJai
changed the title
[Don't Merge]feat(python): updates python support
feat(python): updates python support
Jul 30, 2019
arajkumar
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
For a better readability and maintainability, We should consider to clean up & keep the above snippet as a separate python file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.