Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update to latest fabric8-analytics-lsp-server to 0.2.1 #381

Merged
merged 3 commits into from
Jun 25, 2020
Merged

chore: Update to latest fabric8-analytics-lsp-server to 0.2.1 #381

merged 3 commits into from
Jun 25, 2020

Conversation

mathur07
Copy link
Member

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@mathur07 mathur07 changed the title Update to latest lsp version Update to latest lsp version 0.2.1 Jun 25, 2020
dvandra
dvandra approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@dvandra dvandra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mathur07 You also have to update the "package-lock.json" accordingly.

Correct @arajkumar ?

@dvandra
Copy link
Member

dvandra commented Jun 25, 2020

[test]

2 similar comments
@mathur07
Copy link
Member Author

[test]

@mathur07
Copy link
Member Author

[test]

@arajkumar
Copy link
Member

@mathur07 You need to update package-lock.json as well. Do the following steps,

  1. Update lsp version in package.json
  2. Run npm install (it will update package-lock.json)
  3. Add both package.json & package-lock.json for review

@dvandra
Copy link
Member

dvandra commented Jun 25, 2020

Screenshot from 2020-06-25 12-50-34

@arajkumar arajkumar changed the title Update to latest lsp version 0.2.1 chore: Update to latest fabric8-analytics-lsp-server to 0.2.1 Jun 25, 2020
arajkumar
arajkumar approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@arajkumar arajkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mathur07 mathur07 merged commit c67d6b2 into fabric8-analytics:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arajkumar arajkumar arajkumar approved these changes

@dvandra dvandra dvandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mathur07 @centos-ci @dvandra @arajkumar