Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-safe events #42

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Type-safe events #42

merged 2 commits into from
Aug 8, 2023

Conversation

edgarfgp
Copy link
Member

@edgarfgp edgarfgp commented Aug 7, 2023

To help avoid crashes in mapping to events, Fabulous now uses a specialized type instead of obj to store a message for events with no args.

Also, changed ValueEventData.create and ValueEventData.createVOption to implicitly box the resulting message.

Similar to fabulous-dev/Fabulous.Avalonia#163

@edgarfgp edgarfgp marked this pull request as ready for review August 8, 2023 10:22
src/Fabulous.MauiControls/Views/Cells/EntryCell.fs Outdated Show resolved Hide resolved
src/Fabulous.MauiControls/Views/Cells/SwitchCell.fs Outdated Show resolved Hide resolved
src/Fabulous.MauiControls/Views/Controls/CheckBox.fs Outdated Show resolved Hide resolved
src/Fabulous.MauiControls/Views/Controls/DatePicker.fs Outdated Show resolved Hide resolved
src/Fabulous.MauiControls/Views/Controls/Editor.fs Outdated Show resolved Hide resolved
src/Fabulous.MauiControls/Views/Controls/RadioButton.fs Outdated Show resolved Hide resolved
src/Fabulous.MauiControls/Views/Controls/RadioButton.fs Outdated Show resolved Hide resolved
src/Fabulous.MauiControls/Views/Controls/SearchBar.fs Outdated Show resolved Hide resolved
src/Fabulous.MauiControls/Views/Controls/Switch.fs Outdated Show resolved Hide resolved
src/Fabulous.MauiControls/Views/Controls/TimePicker.fs Outdated Show resolved Hide resolved
Copy link
Member

@TimLariviere TimLariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@TimLariviere TimLariviere added this pull request to the merge queue Aug 8, 2023
Merged via the queue into main with commit b87f4be Aug 8, 2023
1 check passed
@TimLariviere TimLariviere deleted the type-safe-events branch August 8, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants