Dispose properly ViewNode and Component when Widget is removed from tree #1066
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New dependency tree:
When Fabulous detects a widget is removed from the view tree, it will dispose the associated ViewNode, which in turn will dispose the whole dependency tree.
We need to rely on
ViewNode.Dispose()
because frameworks like Maui doesn't provide any event telling us when a control is removed from the UI tree. TheUnloaded
event of Maui for example is called as soon as the control is no longer visible (eg we navigated to another page, but the previous page is still supposed to be alive)