Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type for PUBLIC_URL in cra-template-typescript #8852

Closed
wants to merge 1 commit into from

Conversation

JeromeDeLeon
Copy link
Contributor

@JeromeDeLeon JeromeDeLeon commented Apr 18, 2020

I don't know if it's intentional or not, but I when I ran my code, TS yelled at me that there was typescript error saying the statement below for serviceWorker.ts.

Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
  Type 'undefined' is not assignable to type 'string'.

casaub0n added a commit to casaub0n/casaub0n-gh that referenced this pull request Apr 18, 2020
I followed this PR that's [Fix type for PUBLIC_URL in cra-template-typescript by JeromeDeLeon · Pull Request #8852 · facebook/create-react-app](facebook/create-react-app#8852)
@stale
Copy link

stale bot commented May 18, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label May 18, 2020
@stale
Copy link

stale bot commented May 23, 2020

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

@stale stale bot closed this May 23, 2020
@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants