Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing instructions for the script that downloads artifacts from CircleCI #3795

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

cipolleschi
Copy link
Contributor

This PR adds further instructions on how to test the release flow before a Release, describing how to leverage the new -c parameter.

Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to wait to backport this to 72 and 71 before merging, aside from that LGTM

@netlify
Copy link

netlify bot commented Jul 21, 2023

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 86ae259
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/64d243339847090008df277d
😎 Deploy Preview https://deploy-preview-3795--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: Nicola Corti <corti.nico@gmail.com>
Copy link
Contributor

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can't wait to use the script 😍

website/contributing/release-testing.md Outdated Show resolved Hide resolved
website/contributing/release-testing.md Show resolved Hide resolved
Co-authored-by: Marek Fořt <marekfort@me.com>
@cipolleschi cipolleschi merged commit a2d6242 into main Aug 8, 2023
3 checks passed
@cipolleschi cipolleschi deleted the cipolleschi/improved-release-testing branch August 8, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants