Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOCAL] Fix Ruby Tests for 0.72 #38919

Closed
wants to merge 5 commits into from

Commits on Aug 8, 2023

  1. Update new_architecture.rb for React-ImageManager (#38247)

    Summary:
    This added React-ImageManager to the use_frameworks! - a lot of rpm modules podspec need this.
    
    bypass-github-export-checks
    
    [iOS] [FIXED] - Add React-ImageManager path to work with use_frameworks!
    
    For more details, see:
    https://reactnative.dev/contributing/changelogs-in-pull-requests
    
    Pull Request resolved: #38247
    
    Test Plan: Should not be breaking - it will add to the header_search_paths React-ImageManager
    
    Reviewed By: dmytrorykun
    
    Differential Revision: D47593749
    
    Pulled By: cipolleschi
    
    fbshipit-source-id: a66e90707e5fa73573deab1f04e8d8693869a90c
    billnbell authored and fortmarek committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    1761aea View commit details
    Browse the repository at this point in the history
  2. Fix missing Platform in VirtualizedList

    Luna Wei committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    abedc58 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3386bb4 View commit details
    Browse the repository at this point in the history
  4. Restore checking shadow tree commit cancellation after commit hook ex…

    …ecution (#38715)
    
    Summary:
    Hello! This PR is a fix for one merged some time ago (#36216). In the PR check for `nullptr` value of `newRootShadowNode` just after performing commit hooks was overlooked. This PR restores previous behaviour of conditional commit cancellation after commit hook execution.
    
    ## Changelog:
    
    [INTERNAL] [FIXED] - Restore checking shadow tree commit cancellation after commit hook execution
    
    Pull Request resolved: #38715
    
    Test Plan: Just register a commit hook that return `nullptr`. In that case current code crashes due to `nullptr` dereference.
    
    Reviewed By: sammy-SC
    
    Differential Revision: D47972245
    
    Pulled By: ryancat
    
    fbshipit-source-id: 7599ad11ed4b2dcaf25e53f676ec4530e37410d5
    michalmaka authored and Luna Wei committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    c7f0261 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Configuration menu
    Copy the full SHA
    db81d8f View commit details
    Browse the repository at this point in the history