Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][iOS]Rename BUILD_FROM_SOURCE to RCT_BUILD_HERMES_FROM_SOURCE #43247

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Feb 29, 2024

Summary:

In OSS we have reports like this one where env variables from different settings might clash together, making react native apps fail to build hermes.

For example, a team might have defined a BUILD_FROM_SOURCE env variable to build their specific project from source and that will clash with how react native apps installs Hermes.

This change disambiguate the BUILD_FROM_SOURCE flag we have internally, moving to a less likely to clash RCT_BUILD_HERMES_FROM_SOURCE.

Changelog:

[iOS][Breaking] - Rename BUILD_FROM_SOURCE to RCT_BUILD_HERMES_FROM_SOURCE

Test Plan:

CircleCI

@cipolleschi cipolleschi changed the base branch from main to 0.72-stable February 29, 2024 10:36
@cipolleschi cipolleschi marked this pull request as ready for review February 29, 2024 10:37
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Feb 29, 2024
@huntie huntie merged commit a215805 into 0.72-stable Feb 29, 2024
62 of 66 checks passed
@huntie huntie deleted the cipolleschi/fix-hermes-bfs-072 branch February 29, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants