Shallow renderer passes context to componentWillReceiveProps #10342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter was accidentally omitted before. Leland reported it because it impacts Enzyme. I also added a basic lifecycle parameter test for shallow renderer.
bvaughn
force-pushed
the
shallow-renderer-componentWillReceiveProps-context-param
branch
from
0033663
to
0a0dd56
Compare
|
|
sophiebits
approved these changes
Aug 2, 2017
Closed
bvaughn
deleted the
shallow-renderer-componentWillReceiveProps-context-param
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent conversation between @lelandrichardson, @flarnie, and myself, @lelandrichardson pointed out that the new React 16 shallow renderer did not pass the 2nd param,
context, tocomponentWillReceiveProps.This was an oversight that has been corrected with this PR. I also added a new test to ensure that the new shallow renderer passes the expected params (and only those params) to each lifecycle method.