Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share Object.assign polyfill between UMD builds #10671

Merged
merged 1 commit into from
Sep 11, 2017

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Sep 11, 2017

This wins back 0.3k post min/gzip which we lost due to adding license headers 😛 We can later share more utilities like this, since currently it's suboptimal that some fbjs things are duplicated. This only affects UMD builds.

How I verified it works:

It only affects UMD builds and doesn’t affect any other builds.
This is not global shared state, it's just manual deduplication.

Copy link
Collaborator

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, ok

@gaearon gaearon merged commit f74981b into facebook:master Sep 11, 2017
@bvaughn bvaughn mentioned this pull request Sep 14, 2017
@gaearon gaearon deleted the share-assign branch September 14, 2017 13:26
@gaearon gaearon mentioned this pull request Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants