Remove undocumented TestUtils methods #10681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
approved these changes
Sep 12, 2017
danseethaler
added a commit
to danseethaler/react
that referenced
this pull request
Sep 13, 2017
This reverts commit 18d6cb5.
danseethaler
added a commit
to danseethaler/react
that referenced
this pull request
Sep 13, 2017
This reverts commit 18d6cb5.
danseethaler
added a commit
to danseethaler/react
that referenced
this pull request
Sep 13, 2017
This reverts commit 18d6cb5.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods are not documented. Internally there's just one match of
isCompositeComponentElementwhich is trivial to inline. The other two methods are not used internally, and have been broken in all 16 betas and RCs.Enzyme technically imports them but doesn’t use. They don’t want to remove them until we remove them (enzymejs/enzyme#1023). So let’s just remove before 16.