Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass host context to finalizeInitialChildren #11970

Merged
merged 2 commits into from
Jan 5, 2018
Merged

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Jan 5, 2018

I’m sorry i didn’t include a test, i wasn’t sure where or how to confirm this in one. I’m happy to add it if someone has a sense on where to stick it.

for reference for the change: jquense/react-dom-lite#14 (comment)

gaearon
gaearon previously requested changes Jan 5, 2018
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already retrieved here, we should pass it to updateHostComponent instead of reading it again.

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI passes

@jquense jquense merged commit 8d336aa into master Jan 5, 2018
@jquense jquense deleted the reconciler-context branch January 5, 2018 15:52
yenshih pushed a commit to yenshih/react that referenced this pull request Jan 6, 2018
* pass host context to finalizeInitialChildren

* don't retrieve context an extra time
ManasJayanth pushed a commit to ManasJayanth/react that referenced this pull request Jan 12, 2018
* pass host context to finalizeInitialChildren

* don't retrieve context an extra time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants