Effects list refactor continued: did-bailout flag #19322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b044185:
|
Details of bundled changes.Comparing: 61dd00d...b044185 react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
Details of bundled changes.Comparing: 61dd00d...b044185 react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (experimental) |
Closed
Process deletions as we traverse the tree during commit, before we process other effects. This has the result of better mimicking the previous sequencing.
bvaughn
force-pushed
the
effects_list_refactor_bailout_flag
branch
from
0d1a83e
to
7171494
Compare
trueadm
reviewed
Jul 13, 2020
trueadm
reviewed
Jul 13, 2020
trueadm
reviewed
Jul 13, 2020
trueadm
reviewed
Jul 13, 2020
packages/react-reconciler/src/ReactFiberHydrationContext.new.js
Outdated
Show resolved
Hide resolved
|
Overall the implementation looks right, exactly what I had expected. 👍 There are a few other bailout cases in begin phase where we need to set the react/packages/react-reconciler/src/ReactFiberBeginWork.new.js Lines 1842 to 1848 in 9ea0f67 Basically anywhere there's a |
acdlite
reviewed
Jul 13, 2020
acdlite
reviewed
Jul 13, 2020
acdlite
reviewed
Jul 13, 2020
| export const DidBailout = /* */ 0b0001; | ||
| export const BeforeMutation = /* */ 0b0010; | ||
| export const Mutation = /* */ 0b0100; | ||
| export const Layout = /* */ 0b1000; |
There was a problem hiding this comment.
As a follow up, we should move the Incomplete, ShouldCapture, and DidCapture flags to this new field.
This was referenced Sep 8, 2024
[Snyk] Upgrade: react, react-dom
https-quantumblockchainai-atlassian-net/edgio-astro-ssr-example#940
Open
This was referenced Sep 9, 2024
[Snyk] Upgrade: react, react-dom
https-quantumblockchainai-atlassian-net/edgio-astro-ssr-example#944
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #19261
subtreeTagto use its own meta values rather than copyingeffectTagvalues.View only the delta.