Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed invalid DevTools work tags #20362

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Fixed invalid DevTools work tags #20362

merged 2 commits into from
Dec 1, 2020

Commits on Dec 1, 2020

  1. Fixed invalid DevTools work tags 

    Work tags changed recently (PR facebook#13902) but we didn't bump React versions. This meant that DevTools has valid work tags only for master (and FB www sync) but invalid work tags for the latest open source releases. To fix this, I incremneted React's version in Git (without an actual release) and added a new fork to the work tags detection branch.

This commit also adds tags for the experimental Scope and Fundamental APIs to DevTools so component names will at least display correctly. Technically these new APIs were first introduced to experimental builds ~16.9 but I didn't add a new branch to the work tags fork because I don't they're used commonly. I've just added them to the 17+ branches.
    Brian Vaughn committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    cfc3565 View commit details
    Browse the repository at this point in the history

  2. Removed FundamentalComponent from DevTools tag defs

    Brian Vaughn committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    127381d View commit details
    Browse the repository at this point in the history