Commits on Feb 12, 2021

1. Bailout in sync task if work is not sync …

   Because we don't cancel synchronous tasks, sometimes more than one
   synchronous task ends up being scheduled. This is an artifact of the
   fact that we have two different lanes that schedule sync tasks: discrete
   and sync. So what can happen is that a discrete update gets scheduled,
   then a sync update right after that. Because sync is encoded as higher
   priority than discrete, we schedule a second sync task. And since we
   don't cancel the first one, there are now two separate sync tasks.
   
   As a next step, what we should do is merge InputDiscreteLane with
   SyncLane, then (I believe) this extra bailout wouldn't be necessary,
   because there's nothing higher priority than sync that would cause us to
   cancel it. Though we may want to add logging to be sure.

   

   acdlite committed Feb 12, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 4e86167
   • Browse repository at this point

   Copy the full SHA

   4e86167 View commit details

   Browse the repository at this point in the history