Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduling Profiler: Add network measures #22112

Merged
merged 5 commits into from
Aug 18, 2021
Merged

Scheduling Profiler: Add network measures #22112

merged 5 commits into from
Aug 18, 2021

Commits on Aug 17, 2021

  1. Text utils (draw and measure) performance improvements 

    Better handle the case of extemely long strings (which previously draw and measures by removing one character at a time) to instead use a binary search pattern of finding the biggest string that fits.
    Brian Vaughn committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    95a1f38 View commit details
    Browse the repository at this point in the history

  2. Slightly tweaked scroll event bubbling behavior 

    Don't allow wheel events to bubble past this view even if we've scrolled to the edge. It just feels bad to have the scrolling jump unexpectedly from in a container to the outer page. The only exception is when the container fitst the contnet (no scrolling).

Also don't prevent mouse move events from bubbling if dragging horizontally within a vertical scroll view or vertically within a horizontal scroll view.
    Brian Vaughn committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    8279dc8 View commit details
    Browse the repository at this point in the history

  3. Added Network measures to the Scheduling Profiler 

    Also slightly refactored the preprocessData data function to split separate sections out into helper functions for readability. (We can do more of this for other mark types in a follow up commit.)
    Brian Vaughn committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    62dffa6 View commit details
    Browse the repository at this point in the history

  4. Updated scheduling profiler test snapshots

    Brian Vaughn committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    033f932 View commit details
    Browse the repository at this point in the history

  5. Adjust canvas borders to account for high DPI screens

    Brian Vaughn committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    59a37bf View commit details
    Browse the repository at this point in the history