Reapply changes from #22631 #22645
Merged
Reapply changes from #22631 #22645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
approved these changes
Oct 28, 2021
| @@ -56,7 +55,6 @@ function setup(hook, extensionId) { | |||
| { | |||
| source: 'react-devtools-bridge', | |||
| payload: {event, payload}, | |||
| extensionId, | |||
There was a problem hiding this comment.
Oooh so this was something we missed in #22638?
There was a problem hiding this comment.
yeah, although it shouldn't really cause any issues
| @@ -149,7 +150,7 @@ function createPanelIfReactLoaded() { | |||
|
|
|||
| store = new Store(bridge, { | |||
| isProfiling, | |||
| supportsReloadAndProfile: isChrome, | |||
| supportsReloadAndProfile: isChrome || isEdge, | |||
|
@Sarkar44 Not sure what your comment is referencing but this PR has already been merged. |
KamranAsif
pushed a commit
to KamranAsif/react
that referenced
this pull request
Nov 4, 2021
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally reverted these in #22638
Audited the commits listed here to make sure none of those changes were missed: #22638 (comment)