Fix module-boundary wrappers #22688

bvaughn · 2021-11-03T18:12:23Z

Resolves #22673

Also fixes the scope of 'use strict'; (which the previous change had bumped slightly down in the function, breaking it).

Before I added the module boundary wrappers:

/** @license React vundefined
 * react.development.js
 *
 * Copyright (c) Facebook, Inc. and its affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */

"use strict";

if (process.env.NODE_ENV !== "production") {
  (function () {
    "use strict";

    var _assign = require("object-assign");

    // Other code ...

    exports.version = ReactVersion;
  })();
}

Before the changes in this PR (with module wrappers):

/** @license React vundefined
 * react.development.js
 *
 * Copyright (c) Facebook, Inc. and its affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */

"use strict";

if (process.env.NODE_ENV !== "production") {
  (function () {
    /**
     * Copyright (c) Facebook, Inc. and its affiliates.
     *
     * This source code is licensed under the MIT license found in the
     * LICENSE file in the root directory of this source tree.
     */

    /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */

    // Don't require this file directly; it's embedded by Rollup during build.

    if (
      typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ !== "undefined" &&
      typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart ===
        "function"
    ) {
      __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
    }
    ("use strict");

    var _assign = require("object-assign");

    // ...

    exports.version = ReactVersion;
    /**
     * Copyright (c) Facebook, Inc. and its affiliates.
     *
     * This source code is licensed under the MIT license found in the
     * LICENSE file in the root directory of this source tree.
     */

    /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */

    // Don't require this file directly; it's embedded by Rollup during build.

    if (
      typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ !== "undefined" &&
      typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop ===
        "function"
    ) {
      __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop(new Error());
    }
  })();
}

After the changes in this PR:

/** @license React vundefined
 * react.development.js
 *
 * Copyright (c) Facebook, Inc. and its affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */

"use strict";

if (process.env.NODE_ENV !== "production") {
  (function () {
    "use strict";

    /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
    if (
      typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ !== "undefined" &&
      typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart ===
        "function"
    ) {
      __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
    }
    var _assign = require("object-assign");

    // ...

    // Other code ...

    exports.version = ReactVersion;
    /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
    if (
      typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ !== "undefined" &&
      typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop ===
        "function"
    ) {
      __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop(new Error());
    }
  })();
}

…boundary wrapper code

sizebot · 2021-11-03T18:17:32Z

Comparing: 255221c...7f91d9d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	129.55 kB	129.55 kB	=	41.43 kB	41.43 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	134.52 kB	134.52 kB	=	42.89 kB	42.89 kB
facebook-www/ReactDOM-prod.classic.js	=	423.36 kB	423.36 kB	=	78.05 kB	78.05 kB
facebook-www/ReactDOM-prod.modern.js	=	411.92 kB	411.92 kB	=	76.30 kB	76.30 kB
facebook-www/ReactDOMForked-prod.classic.js	=	423.36 kB	423.36 kB	=	78.06 kB	78.06 kB
facebook-www/Scheduler-dev.classic.js	=	25.19 kB	24.67 kB	=	6.67 kB	6.62 kB
facebook-www/Scheduler-dev.modern.js	=	25.19 kB	24.67 kB	=	6.67 kB	6.62 kB
facebook-www/React-profiling.classic.js	=	18.54 kB	18.02 kB	=	4.64 kB	4.59 kB
facebook-www/React-profiling.modern.js	=	18.39 kB	17.87 kB	=	4.59 kB	4.54 kB
facebook-react-native/react/cjs/React-profiling.js	=	18.31 kB	17.79 kB	=	4.56 kB	4.51 kB
facebook-react-native/scheduler/cjs/Scheduler-dev.js	=	18.04 kB	17.52 kB	=	4.99 kB	4.94 kB
oss-experimental/scheduler/cjs/scheduler.development.js	=	18.04 kB	17.51 kB	=	4.99 kB	4.93 kB
oss-stable-semver/scheduler/cjs/scheduler.development.js	=	18.04 kB	17.51 kB	=	4.99 kB	4.93 kB
oss-stable/scheduler/cjs/scheduler.development.js	=	18.04 kB	17.51 kB	=	4.99 kB	4.93 kB
facebook-www/Scheduler-profiling.classic.js	=	16.42 kB	15.90 kB	=	3.76 kB	3.71 kB
facebook-www/Scheduler-profiling.modern.js	=	16.42 kB	15.90 kB	=	3.76 kB	3.71 kB
facebook-react-native/scheduler/cjs/Scheduler-profiling.js	=	11.39 kB	10.88 kB	=	2.79 kB	2.74 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim.development.js	=	8.92 kB	8.38 kB	=	3.22 kB	3.18 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim.development.js	=	8.92 kB	8.38 kB	=	3.22 kB	3.18 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim.development.js	=	8.92 kB	8.38 kB	=	3.22 kB	3.18 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js	=	8.33 kB	7.80 kB	=	3.12 kB	3.08 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js	=	8.33 kB	7.80 kB	=	3.12 kB	3.08 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js	=	8.33 kB	7.80 kB	=	3.12 kB	3.08 kB
oss-experimental/create-subscription/cjs/create-subscription.development.js	=	6.91 kB	6.38 kB	=	2.27 kB	2.23 kB
oss-stable-semver/create-subscription/cjs/create-subscription.development.js	=	6.91 kB	6.38 kB	=	2.27 kB	2.23 kB
oss-stable/create-subscription/cjs/create-subscription.development.js	=	6.91 kB	6.38 kB	=	2.27 kB	2.23 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js	=	6.24 kB	5.70 kB	=	1.88 kB	1.83 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js	=	6.24 kB	5.70 kB	=	1.88 kB	1.83 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js	=	6.24 kB	5.70 kB	=	1.88 kB	1.83 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js	=	6.18 kB	5.65 kB	=	1.86 kB	1.81 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js	=	6.18 kB	5.65 kB	=	1.86 kB	1.81 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js	=	6.18 kB	5.65 kB	=	1.86 kB	1.81 kB
oss-experimental/use-subscription/cjs/use-subscription.development.js	=	6.16 kB	5.63 kB	=	2.13 kB	2.08 kB
oss-stable-semver/use-subscription/cjs/use-subscription.development.js	=	6.16 kB	5.63 kB	=	2.13 kB	2.08 kB
oss-stable/use-subscription/cjs/use-subscription.development.js	=	6.16 kB	5.63 kB	=	2.13 kB	2.08 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store.development.js	=	3.37 kB	2.84 kB	=	1.32 kB	1.27 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store.development.js	=	3.37 kB	2.84 kB	=	1.32 kB	1.27 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store.development.js	=	3.37 kB	2.84 kB	=	1.32 kB	1.27 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-experimental/react-dom/cjs/react-dom.profiling.min.js	=	144.58 kB	144.06 kB	=	46.01 kB	45.78 kB
oss-stable-semver/react-dom/cjs/react-dom.profiling.min.js	=	139.59 kB	139.07 kB	=	44.48 kB	44.25 kB
oss-stable/react-dom/cjs/react-dom.profiling.min.js	=	139.59 kB	139.07 kB	=	44.48 kB	44.25 kB
facebook-www/React-dev.classic.js	=	115.37 kB	114.85 kB	=	28.45 kB	28.28 kB
facebook-www/React-dev.modern.js	=	114.35 kB	113.83 kB	=	28.26 kB	28.08 kB
facebook-react-native/react/cjs/React-dev.js	=	105.48 kB	104.96 kB	=	25.78 kB	25.60 kB
oss-experimental/react/cjs/react.development.js	=	89.91 kB	89.38 kB	=	24.17 kB	23.99 kB
oss-stable-semver/react/cjs/react.development.js	=	89.24 kB	88.70 kB	=	24.09 kB	23.91 kB
oss-stable/react/cjs/react.development.js	=	89.24 kB	88.70 kB	=	24.09 kB	23.91 kB
facebook-www/Scheduler-dev.classic.js	=	25.19 kB	24.67 kB	=	6.67 kB	6.62 kB
facebook-www/Scheduler-dev.modern.js	=	25.19 kB	24.67 kB	=	6.67 kB	6.62 kB
facebook-www/React-profiling.classic.js	=	18.54 kB	18.02 kB	=	4.64 kB	4.59 kB
facebook-www/React-profiling.modern.js	=	18.39 kB	17.87 kB	=	4.59 kB	4.54 kB
facebook-react-native/react/cjs/React-profiling.js	=	18.31 kB	17.79 kB	=	4.56 kB	4.51 kB
facebook-react-native/scheduler/cjs/Scheduler-dev.js	=	18.04 kB	17.52 kB	=	4.99 kB	4.94 kB
oss-experimental/scheduler/cjs/scheduler.development.js	=	18.04 kB	17.51 kB	=	4.99 kB	4.93 kB
oss-stable-semver/scheduler/cjs/scheduler.development.js	=	18.04 kB	17.51 kB	=	4.99 kB	4.93 kB
oss-stable/scheduler/cjs/scheduler.development.js	=	18.04 kB	17.51 kB	=	4.99 kB	4.93 kB
facebook-www/Scheduler-profiling.classic.js	=	16.42 kB	15.90 kB	=	3.76 kB	3.71 kB
facebook-www/Scheduler-profiling.modern.js	=	16.42 kB	15.90 kB	=	3.76 kB	3.71 kB
facebook-react-native/scheduler/cjs/Scheduler-profiling.js	=	11.39 kB	10.88 kB	=	2.79 kB	2.74 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim.development.js	=	8.92 kB	8.38 kB	=	3.22 kB	3.18 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim.development.js	=	8.92 kB	8.38 kB	=	3.22 kB	3.18 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim.development.js	=	8.92 kB	8.38 kB	=	3.22 kB	3.18 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js	=	8.33 kB	7.80 kB	=	3.12 kB	3.08 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js	=	8.33 kB	7.80 kB	=	3.12 kB	3.08 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js	=	8.33 kB	7.80 kB	=	3.12 kB	3.08 kB
oss-experimental/create-subscription/cjs/create-subscription.development.js	=	6.91 kB	6.38 kB	=	2.27 kB	2.23 kB
oss-stable-semver/create-subscription/cjs/create-subscription.development.js	=	6.91 kB	6.38 kB	=	2.27 kB	2.23 kB
oss-stable/create-subscription/cjs/create-subscription.development.js	=	6.91 kB	6.38 kB	=	2.27 kB	2.23 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js	=	6.24 kB	5.70 kB	=	1.88 kB	1.83 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js	=	6.24 kB	5.70 kB	=	1.88 kB	1.83 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js	=	6.24 kB	5.70 kB	=	1.88 kB	1.83 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js	=	6.18 kB	5.65 kB	=	1.86 kB	1.81 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js	=	6.18 kB	5.65 kB	=	1.86 kB	1.81 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js	=	6.18 kB	5.65 kB	=	1.86 kB	1.81 kB
oss-experimental/use-subscription/cjs/use-subscription.development.js	=	6.16 kB	5.63 kB	=	2.13 kB	2.08 kB
oss-stable-semver/use-subscription/cjs/use-subscription.development.js	=	6.16 kB	5.63 kB	=	2.13 kB	2.08 kB
oss-stable/use-subscription/cjs/use-subscription.development.js	=	6.16 kB	5.63 kB	=	2.13 kB	2.08 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store.development.js	=	3.37 kB	2.84 kB	=	1.32 kB	1.27 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store.development.js	=	3.37 kB	2.84 kB	=	1.32 kB	1.27 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store.development.js	=	3.37 kB	2.84 kB	=	1.32 kB	1.27 kB

Generated by 🚫 dangerJS against 7f91d9d

Summary: This sync includes the following changes: - **[c0c71a868](facebook/react@c0c71a868 )**: Re-enable useMutableSource in internal RN ([#22750](facebook/react#22750)) //<Ricky>// - **[cb11155c8](facebook/react@cb11155c8 )**: Add runtime type checks around module boundary code ([#22748](facebook/react#22748)) //<Brian Vaughn>// - **[a04f13d29](facebook/react@a04f13d29 )**: react-refresh@0.11.0 //<Dan Abramov>// - **[ff9897d23](facebook/react@ff9897d23 )**: [React Refresh] support typescript namespace syntax ([#22621](facebook/react#22621)) //<irinakk>// - **[0ddd69d12](facebook/react@0ddd69d12 )**: Throw on hydration mismatch and force client rendering if boundary hasn't suspended within concurrent root ([#22629](facebook/react#22629)) //<salazarm>// - **[c3f34e4be](facebook/react@c3f34e4be )**: eslint-plugin-react-hooks@4.3.0 //<Dan Abramov>// - **[827021c4e](facebook/react@827021c4e )**: Changelog for eslint-plugin-react-hooks@4.3.0 //<Dan Abramov>// - **[8ca3f567b](facebook/react@8ca3f567b )**: Fix module-boundary wrappers ([#22688](facebook/react#22688)) //<Brian Vaughn>// - **[1bf6deb86](facebook/react@1bf6deb86 )**: Renamed packages/react-devtools-scheduling-profiler to packages/react-devtools-timeline ([#22691](facebook/react#22691)) //<Brian Vaughn>// - **[51c558aeb](facebook/react@51c558aeb )**: Rename (some) "scheduling profiler" references to "timeline" ([#22690](facebook/react#22690)) //<Brian Vaughn>// - **[00ced1e2b](facebook/react@00ced1e2b )**: Fix useId in strict mode ([#22681](facebook/react#22681)) //<Andrew Clark>// - **[5cccacd13](facebook/react@5cccacd13 )**: Upgrade useId to alpha channel ([#22674](facebook/react#22674)) //<Andrew Clark>// - **[75f3ddebf](facebook/react@75f3ddebf )**: Remove experimental useOpaqueIdentifier API ([#22672](facebook/react#22672)) //<Andrew Clark>// - **[8c4a05b8f](facebook/react@8c4a05b8f )**: Remove flow pragma comment from module registration start/stop templates ([#22670](facebook/react#22670)) //<Brian Vaughn>// - **[ebf9ae857](facebook/react@ebf9ae857 )**: useId ([#22644](facebook/react#22644)) //<Andrew Clark>// - **[a0d991fe6](facebook/react@a0d991fe6 )**: Re-land #22292 (remove uMS from open source build) ([#22664](facebook/react#22664)) //<Andrew Clark>// - **[6bce0355c](facebook/react@6bce0355c )**: Upgrade useSyncExternalStore to alpha channel ([#22662](facebook/react#22662)) //<Andrew Clark>// - **[7034408ff](facebook/react@7034408ff )**: Follow-up improvements to error code extraction infra ([#22516](facebook/react#22516)) //<Andrew Clark>// - **[90e5d3638](facebook/react@90e5d3638 )**: chore: fix comment typo ([#22615](facebook/react#22615)) //<btea>// - **[3c4c1c470](facebook/react@3c4c1c470 )**: Remove warning for dangling passive effects ([#22609](facebook/react#22609)) //<Andrew Clark>// - **[d5b6b4b86](facebook/react@d5b6b4b86 )**: Expand act warning to cover all APIs that might schedule React work ([#22607](facebook/react#22607)) //<Andrew Clark>// - **[fa9bea0c4](facebook/react@fa9bea0c4 )**: Initial implementation of cache cleanup ([#22510](facebook/react#22510)) //<Joseph Savona>// - **[0e8a5aff3](facebook/react@0e8a5aff3 )**: Scheduling Profiler: Add marks for component effects (mount and unmount) ([#22578](facebook/react#22578)) //<Brian Vaughn>// - **[4ba20579d](facebook/react@4ba20579d )**: Scheduling Profiler: De-emphasize React internal frames ([#22588](facebook/react#22588)) //<Brian Vaughn>// - **[cdb8a1d19](facebook/react@cdb8a1d19 )**: [Fizz] Add option to inject bootstrapping script tags after the shell is injected ([#22594](facebook/react#22594)) //<Sebastian Markbåge>// - **[34e4c9756](facebook/react@34e4c9756 )**: Clear extra nodes if there's a hydration mismatch within a suspense boundary ([#22592](facebook/react#22592)) //<Sebastian Markbåge>// - **[02f411578](facebook/react@02f411578 )**: Upgrade useInsertionEffect to stable ([#22589](facebook/react#22589)) //<Andrew Clark>// - **[2af4a7933](facebook/react@2af4a7933 )**: Hydrate using SuspenseComponent as the parent ([#22582](facebook/react#22582)) //<Sebastian Markbåge>// - **[b1acff0cc](facebook/react@b1acff0cc )**: Enable cache in test renderer ([#22580](facebook/react#22580)) //<Joseph Savona>// - **[996da67b2](facebook/react@996da67b2 )**: Replace global `jest` heuristic with `IS_REACT_ACT_ENVIRONMENT` ([#22562](facebook/react#22562)) //<Andrew Clark>// - **[163e81c1f](facebook/react@163e81c1f )**: Support disabling spurious act warnings with a global environment flag ([#22561](facebook/react#22561)) //<Andrew Clark>// - **[23b7dfeff](facebook/react@23b7dfeff )**: Enable scheduling profiler for RN FB profiling builds ([#22566](facebook/react#22566)) //<Brian Vaughn>// - **[61455a25b](facebook/react@61455a25b )**: Enable experimental Cache API in www TestRenderer ([#22554](facebook/react#22554)) //<Joseph Savona>// - **[7142d110b](facebook/react@7142d110b )**: Bugfix: Nested useOpaqueIdentifier references ([#22553](facebook/react#22553)) //<Andrew Clark>// - **[1e247ff89](facebook/react@1e247ff89 )**: Enabled scheduling profiler marks for React Native FB target ([#22544](facebook/react#22544)) //<Brian Vaughn>// - **[c16b005f2](facebook/react@c16b005f2 )**: Update test and stack frame code to support newer V8 stack formats ([#22477](facebook/react#22477)) //<Brian Vaughn>// - **[55d75005b](facebook/react@55d75005b )**: duplicate value in variable ([#22390](facebook/react#22390)) //<BIKI DAS>// Changelog: [General][Changed] - React Native sync for revisions afcb9cd...c0c71a8 jest_e2e[run_all_tests] Reviewed By: yungsters Differential Revision: D32395873 fbshipit-source-id: 3afd158f167b1eedcc244e29aba1a2c502d3c9d9

Remove duplicate header comment that resulted from build time module-…

7f91d9d

…boundary wrapper code

bvaughn requested review from gaearon, jstejada, rickhanlonii, lunaruan and acdlite November 3, 2021 18:12

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Nov 3, 2021

rickhanlonii approved these changes Nov 4, 2021

View reviewed changes

bvaughn merged commit 8ca3f56 into facebook:main Nov 4, 2021

bvaughn deleted the module-boundary-boilerplate branch November 4, 2021 14:40

KamranAsif pushed a commit to KamranAsif/react that referenced this pull request Nov 4, 2021

Fix module-boundary wrappers (facebook#22688)

d783a62

zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022

Fix module-boundary wrappers (facebook#22688)

1b1da74

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix module-boundary wrappers #22688

Fix module-boundary wrappers #22688

bvaughn commented Nov 3, 2021 •

edited

Loading

sizebot commented Nov 3, 2021

Fix module-boundary wrappers #22688

Fix module-boundary wrappers #22688

Conversation

bvaughn commented Nov 3, 2021 • edited Loading

sizebot commented Nov 3, 2021

Critical size changes

Significant size changes

bvaughn commented Nov 3, 2021 •

edited

Loading