Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the create-subscription package #24288

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Apr 7, 2022

This package doesn't have much use. We don't plan to update it. The built-in useSyncExternalStore in 18 serves the same purpose and works better.

Not to be confused with use-subscription which has some usage.
I'll update that one to use useSyncExternalStore internally.

@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Apr 7, 2022
@gaearon
Copy link
Collaborator Author

gaearon commented Apr 7, 2022

I could push a patch to npm that just updates README to say we recommend uSES instead.

@sizebot
Copy link

sizebot commented Apr 7, 2022

Comparing: f993ffc...397d2a8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.21 kB 131.21 kB = 41.98 kB 41.98 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 136.47 kB 136.47 kB = 43.57 kB 43.57 kB
facebook-www/ReactDOM-prod.classic.js = 434.63 kB 434.63 kB = 79.87 kB 79.87 kB
facebook-www/ReactDOM-prod.modern.js = 419.63 kB 419.63 kB = 77.50 kB 77.50 kB
facebook-www/ReactDOMForked-prod.classic.js = 434.63 kB 434.63 kB = 79.87 kB 79.87 kB
oss-experimental/create-subscription/cjs/create-subscription.development.js Deleted 6.37 kB 0.00 kB Deleted 2.22 kB 0.00 kB
oss-experimental/create-subscription/cjs/create-subscription.production.min.js Deleted 1.96 kB 0.00 kB Deleted 0.94 kB 0.00 kB
oss-experimental/create-subscription/index.js Deleted 0.22 kB 0.00 kB Deleted 0.15 kB 0.00 kB
oss-stable-semver/create-subscription/cjs/create-subscription.development.js Deleted 6.37 kB 0.00 kB Deleted 2.22 kB 0.00 kB
oss-stable-semver/create-subscription/cjs/create-subscription.production.min.js Deleted 1.96 kB 0.00 kB Deleted 0.94 kB 0.00 kB
oss-stable-semver/create-subscription/index.js Deleted 0.22 kB 0.00 kB Deleted 0.15 kB 0.00 kB
oss-stable/create-subscription/cjs/create-subscription.development.js Deleted 6.37 kB 0.00 kB Deleted 2.22 kB 0.00 kB
oss-stable/create-subscription/cjs/create-subscription.production.min.js Deleted 1.96 kB 0.00 kB Deleted 0.94 kB 0.00 kB
oss-stable/create-subscription/index.js Deleted 0.22 kB 0.00 kB Deleted 0.15 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/create-subscription/cjs/create-subscription.development.js Deleted 6.37 kB 0.00 kB Deleted 2.22 kB 0.00 kB
oss-experimental/create-subscription/cjs/create-subscription.production.min.js Deleted 1.96 kB 0.00 kB Deleted 0.94 kB 0.00 kB
oss-experimental/create-subscription/index.js Deleted 0.22 kB 0.00 kB Deleted 0.15 kB 0.00 kB
oss-stable-semver/create-subscription/cjs/create-subscription.development.js Deleted 6.37 kB 0.00 kB Deleted 2.22 kB 0.00 kB
oss-stable-semver/create-subscription/cjs/create-subscription.production.min.js Deleted 1.96 kB 0.00 kB Deleted 0.94 kB 0.00 kB
oss-stable-semver/create-subscription/index.js Deleted 0.22 kB 0.00 kB Deleted 0.15 kB 0.00 kB
oss-stable/create-subscription/cjs/create-subscription.development.js Deleted 6.37 kB 0.00 kB Deleted 2.22 kB 0.00 kB
oss-stable/create-subscription/cjs/create-subscription.production.min.js Deleted 1.96 kB 0.00 kB Deleted 0.94 kB 0.00 kB
oss-stable/create-subscription/index.js Deleted 0.22 kB 0.00 kB Deleted 0.15 kB 0.00 kB

Generated by 🚫 dangerJS against 397d2a8

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@gaearon gaearon merged commit d9a0f9e into facebook:main Apr 11, 2022
@gaearon
Copy link
Collaborator Author

gaearon commented Apr 11, 2022

I released create-subscription@18.0.1 with just the README change so we can archive this.

@gaearon gaearon deleted the delete-cs branch April 11, 2022 19:07
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Apr 26, 2022
Summary:
This sync includes the following changes:
- **[bd4784c8f](facebook/react@bd4784c8f )**: Revert #24236 (Don't recreate the same fallback on the client if hydrating suspends) ([#24434](facebook/react#24434)) //<dan>//
- **[6d3b6d0f4](facebook/react@6d3b6d0f4 )**: forwardRef et al shouldn't affect if props reused ([#24421](facebook/react#24421)) //<Andrew Clark>//
- **[bd0813766](facebook/react@bd0813766 )**: Fix: useDeferredValue should reuse previous value ([#24413](facebook/react#24413)) //<Andrew Clark>//
- **[9ae80d6a2](facebook/react@9ae80d6a2 )**: Suppress hydration warnings when a preceding sibling suspends ([#24404](facebook/react#24404)) //<Josh Story>//
- **[0dc4e6663](facebook/react@0dc4e6663 )**: Land enableClientRenderFallbackOnHydrationMismatch ([#24410](facebook/react#24410)) //<Andrew Clark>//
- **[354772952](facebook/react@354772952 )**: Land enableSelectiveHydration flag ([#24406](facebook/react#24406)) //<Andrew Clark>//
- **[392808a1f](facebook/react@392808a1f )**: Land enableClientRenderFallbackOnTextMismatch flag ([#24405](facebook/react#24405)) //<Andrew Clark>//
- **[1e748b452](facebook/react@1e748b452 )**: Land enableLazyElements flag ([#24407](facebook/react#24407)) //<Andrew Clark>//
- **[4175f0593](facebook/react@4175f0593 )**: Temporarily feature flag numeric fallback for symbols ([#24401](facebook/react#24401)) //<Ricky>//
- **[a6d53f346](facebook/react@a6d53f346 )**: Revert "Clean up Selective Hydration / Event Replay flag ([#24156](facebook/react#24156))" ([#24402](facebook/react#24402)) //<Ricky>//
- **[ab9cdd34f](facebook/react@ab9cdd34f )**: Bugfix: In legacy mode, call suspended tree's unmount effects when it is deleted ([#24400](facebook/react#24400)) //<Andrew Clark>//
- **[168da8d55](facebook/react@168da8d55 )**: Fix typo that happened during rebasing //<Andrew Clark>//
- **[8bc527a4c](facebook/react@8bc527a4c )**: Bugfix: Fix race condition between interleaved and non-interleaved updates ([#24353](facebook/react#24353)) //<Andrew Clark>//
- **[f7cf077cc](facebook/react@f7cf077cc )**: [Transition Tracing] Add Offscreen Queue ([#24341](facebook/react#24341)) //<Luna Ruan>//
- **[4fc394bbe](facebook/react@4fc394bbe )**: Fix suspense fallback throttling ([#24253](facebook/react#24253)) //<sunderls>//
- **[80170a068](facebook/react@80170a068 )**: Match bundle.name and match upper case entry points ([#24346](facebook/react#24346)) //<Sebastian Markbåge>//
- **[fea6f8da6](facebook/react@fea6f8da6 )**: [Transition Tracing] Add transition to OffscreenState and pendingSuspenseBoundaries to RootState ([#24340](facebook/react#24340)) //<Luna Ruan>//
- **[8e2f9b086](facebook/react@8e2f9b086 )**: move passive flag ([#24339](facebook/react#24339)) //<Luna Ruan>//
- **[55a21ef7e](facebook/react@55a21ef7e )**: fix pushTransition for transition tracing ([#24338](facebook/react#24338)) //<Luna Ruan>//
- **[069d23bb7](facebook/react@069d23bb7 )**:  [eslint-plugin-exhaustive-deps] Fix exhaustive deps check for unstable vars ([#24343](facebook/react#24343)) //<Afzal Sayed>//
- **[4997515b9](facebook/react@4997515b9 )**: Point useSubscription to useSyncExternalStore shim ([#24289](facebook/react#24289)) //<dan>//
- **[01e2bff1d](facebook/react@01e2bff1d )**: Remove unnecessary check ([#24332](facebook/react#24332)) //<zhoulixiang>//
- **[d9a0f9e20](facebook/react@d9a0f9e20 )**: Delete create-subscription folder ([#24288](facebook/react#24288)) //<dan>//
- **[f993ffc51](facebook/react@f993ffc51 )**: Fix infinite update loop that happens when an unmemoized value is passed to useDeferredValue ([#24247](facebook/react#24247)) //<Andrew Clark>//
- **[fa5800226](facebook/react@fa5800226 )**: [Fizz] Pipeable Stream Perf ([#24291](facebook/react#24291)) //<Josh Story>//
- **[0568c0f8c](facebook/react@0568c0f8c )**: Replace zero with NoLanes for consistency in FiberLane ([#24327](facebook/react#24327)) //<Leo>//
- **[e0160d50c](facebook/react@e0160d50c )**: add transition tracing transitions stack ([#24321](facebook/react#24321)) //<Luna Ruan>//
- **[b0f13e5d3](facebook/react@b0f13e5d3 )**: add pendingPassiveTransitions ([#24320](facebook/react#24320)) //<Luna Ruan>//

Changelog:
[General][Changed] - React Native sync for revisions 60e63b9...bd4784c

jest_e2e[run_all_tests]

Reviewed By: kacieb

Differential Revision: D35899012

fbshipit-source-id: 86a885e336fca9f0efa80cd2b8ca040f2cb53853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants