#5284 - Show a friendly error when using TestUtils.Simulate with shallow rendering #5358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorhastings
force-pushed
the
invariant-testutils-simulate-shallow-render
branch
from
661c046
to
4a30d74
Compare
|
@conorhastings updated the pull request. |
conorhastings
changed the title
| @@ -470,6 +470,11 @@ ReactShallowRenderer.prototype._render = function(element, transaction, context) | |||
| function makeSimulator(eventType) { | |||
| return function(domComponentOrNode, eventData) { | |||
| var node; | |||
| invariant( | |||
| !React.isValidElement(domComponentOrNode), | |||
| 'TestUtils.Simulate expects a component instance and not a React Element.' + | |||
There was a problem hiding this comment.
nit: Can you write "ReactElement" without a space? That's consistent with our prop types message.
|
Looks great, just a couple nits – if you could fix those and squash your commits that would be perfect! |
conorhastings
force-pushed
the
invariant-testutils-simulate-shallow-render
branch
2 times, most recently
from
07f4538
to
bbecb01
Compare
|
@conorhastings updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
@spicyj thanks for the feedback! updated. |
conorhastings
force-pushed
the
invariant-testutils-simulate-shallow-render
branch
from
bbecb01
to
fbb8d2f
Compare
|
@conorhastings updated the pull request. |
sophiebits
added a commit
that referenced
this pull request
Nov 3, 2015
…ate-shallow-render #5284 - Show a friendly error when using TestUtils.Simulate with shallow rendering
|
Looks great! Thank you. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5284