Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5839 Add error event to source element #6941

Merged
merged 2 commits into from
Jun 8, 2016

Conversation

wadahiro
Copy link
Contributor

@wadahiro wadahiro commented Jun 1, 2016

This fixes issue #5839, and is re-based code from pr #5861.

reactEurope-hackathon

@ghost
Copy link

ghost commented Jun 1, 2016

@wadahiro updated the pull request.

@jimfb
Copy link
Contributor

jimfb commented Jun 8, 2016

@facebook/react-core Technically public API, so cc @facebook/react-core.

Should be safe / relatively unobjectionable, and it has been accepted for over a week now, so I'm shipping it.

@jimfb jimfb merged commit 518336e into facebook:master Jun 8, 2016
@zpao zpao added this to the 15-next milestone Jun 8, 2016
zpao pushed a commit that referenced this pull request Jun 14, 2016
* Fix #5839 Add error event to source element

* Add test case for <source onError={callback}>

(cherry picked from commit 518336e)
@zpao zpao modified the milestones: 15-next, 15.2.0 Jun 14, 2016
@wadahiro wadahiro deleted the add-error-event-to-source branch June 17, 2016 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants