Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change trackedTouchCount invariant into a console.error #7400

Merged
merged 2 commits into from
Aug 2, 2016

Conversation

yungsters
Copy link
Contributor

Doing to ResponderEventPlugin what #7143 did to ResponderTouchHistoryStore. This changes the invariant that currently fatals React Native environments when touch events are misfired to instead fail gracefully via console.error.

Reviewers: @spicyj, @jingc

Test Plan:
Ran grunt test and flow ./src successfully.

@sophiebits
Copy link
Collaborator

👍

@sophiebits sophiebits added this to the 15-next milestone Aug 2, 2016
@yungsters
Copy link
Contributor Author

Hmm... Travis CI failed, but the failure does not seem relevant. Merge anyway?

@yungsters
Copy link
Contributor Author

Oh, never mind. It was a lint warning, will fix.

@yungsters yungsters merged commit 0fb8feb into facebook:master Aug 2, 2016
@yungsters yungsters deleted the touch branch August 2, 2016 05:42
@zpao zpao modified the milestones: 15.3.1, 15-next Aug 12, 2016
zpao pushed a commit that referenced this pull request Aug 12, 2016
* Change `trackedTouchCount` invariant into a console.error

* Fix ResponderEventPlugin lint warning

(cherry picked from commit 0fb8feb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants