Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controlList to DOM property whitelist #9940

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

nhunzaker
Copy link
Contributor

Addresses #9594. Long term, we can ignore this sort of stuff, but the attribute white list change hasn't landed (will it for 15.x?).

Testing:

I've hoisted this build of React on surge.sh and setup a fiddle:
https://jsfiddle.net/84v837e9/88/

The video tag should correctly receive the controlList attribute.

More info:

Copy link
Contributor

@aweary aweary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending doc fix

@@ -104,8 +104,8 @@ React supports all `data-*` and `aria-*` attributes as well as these attributes:
accept acceptCharset accessKey action allowFullScreen allowTransparency alt
async autoComplete autoFocus autoPlay capture cellPadding cellSpacing challenge
charSet checked cite classID className colSpan cols content contentEditable
contextMenu controls coords crossOrigin data dateTime default defer dir
disabled download draggable encType form formAction formEncType formMethod
contextMenu controls controlList coords crossOrigin data dateTime default defer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "controlsList" right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@nhunzaker nhunzaker force-pushed the gh-9594-control-list-attribute branch from 08e8f9b to 331ef3e Compare June 13, 2017 01:07
@nhunzaker
Copy link
Contributor Author

Got it. I'll cherry pick to 15.6

@nhunzaker nhunzaker merged commit d715765 into facebook:master Jun 13, 2017
@aweary aweary mentioned this pull request Jul 13, 2017
12 tasks
@nhunzaker nhunzaker mentioned this pull request Aug 10, 2017
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants