statistics: make tickers and histograms extendible #6107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
yiwu-arbug
reviewed
Dec 2, 2019
| @@ -541,6 +541,8 @@ class Statistics { | |||
| }; | |||
|
|
|||
| // Create a concrete DBStatistics object | |||
| template <uint32_t TICKER_MAX = TICKER_ENUM_MAX, | |||
There was a problem hiding this comment.
Can we keep the existing API unchanged and add the template version of CreateDBStatistics to another header file under include/rocksdb/utilities?
|
CI failure seems to be travis error only. |
|
@siying @miasantreble any comment on this one? This would allow application to reuse the core-local statistics implementation. Thanks. |
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For outer plugins, they may want to store its statistics into Rocksdb's statistics to leverage the cache-friendly optimization. So making
StatisticsImplas a template to let outer users reserve a larger place inStatisticsData.The changes are:
StatisticsImplas a template