Skip to content

Commit

Permalink
Improve error messaging for name resolution failure (#174)
Browse files Browse the repository at this point in the history
  • Loading branch information
cbalioglu authored Nov 22, 2023
1 parent 6e21fad commit edb4289
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/fairseq2/assets/download_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from tarfile import TarFile, is_tarfile
from tempfile import NamedTemporaryFile
from typing import Dict, Optional, final
from urllib.error import HTTPError
from urllib.error import HTTPError, URLError
from urllib.parse import unquote, urlparse
from urllib.request import Request, urlopen
from zipfile import BadZipFile, ZipFile
Expand Down Expand Up @@ -368,6 +368,10 @@ def remove_cache_dir() -> None:

try:
response = cleanup_stack.enter_context(urlopen(request))
except URLError as ex:
raise AssetDownloadError(
f"The download of the {self.display_name} has failed. See nested exception for details."
) from ex
except HTTPError as ex:
raise AssetDownloadError(
f"The download of the {self.display_name} has failed with the HTTP error code {ex.code}."
Expand Down

0 comments on commit edb4289

Please sign in to comment.