Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messaging for name resolution failure #174

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Improve error messaging for name resolution failure #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/fairseq2/assets/download_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from tarfile import TarFile, is_tarfile
from tempfile import NamedTemporaryFile
from typing import Dict, Optional, final
from urllib.error import HTTPError
from urllib.error import HTTPError, URLError
from urllib.parse import unquote, urlparse
from urllib.request import Request, urlopen
from zipfile import BadZipFile, ZipFile
Expand Down Expand Up @@ -368,6 +368,10 @@ def remove_cache_dir() -> None:

try:
response = cleanup_stack.enter_context(urlopen(request))
except URLError as ex:
raise AssetDownloadError(
f"The download of the {self.display_name} has failed. See nested exception for details."
) from ex
except HTTPError as ex:
raise AssetDownloadError(
f"The download of the {self.display_name} has failed with the HTTP error code {ex.code}."
Expand Down