Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pmcx incorrectly set default source focal length to 1 #180

Closed
fangq opened this issue Aug 25, 2023 · 0 comments
Closed

pmcx incorrectly set default source focal length to 1 #180

fangq opened this issue Aug 25, 2023 · 0 comments
Assignees
@fangq
Labels
bug

Comments

@fangq
Copy link
Owner

fangq commented Aug 25, 2023

it appears that this is a severe bug affecting all past pmcx versions - that the default source focal length is 1, which should have been 0 (disabled).

This bug yields incorrect results for all area sources, including fourier, disk, planar and more. It does not affect point sources such as cone/pencil/isotropic.

this was reported in this mailing list post by Gijs Buist:

https://groups.google.com/g/mcx-users/c/SFl6HskLGxU
@fangq fangq self-assigned this Aug 25, 2023
@fangq fangq added the bug label Aug 25, 2023
@fangq fangq closed this as completed in eaf31de Aug 25, 2023
fangq added a commit that referenced this issue Aug 25, 2023
@fangq
bump pmcx version to 0.1.1 to fix critical bug #180
0be475b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fangq fangq

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fangq