compact implementation of ring source, close #181 #182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@leoyala, here is my simplified implementation for the ring/ring sector source you proposed in #181. I reused most of the code in the
disk
source and this patch does not introduce additional registers.I am not fully sure I understand your
srcparam1.z/w
settings. can you explain? in my implementation, .z/.w are simply lower and higher bound of the ring angle.also, can you explain your
srcparam2.x
? mcx already usescfg.srcdir(4)
as the focal length (negative flocal length generates a diverging beam), I am wondering ifsrcdir(4)
is sufficient to simulate the effect you desired.