Another go at updating dependencies #192
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,7 +25,7 @@ structures: | |
| * [Bifunctor](#bifunctor) | ||
| * [Profunctor](#profunctor) | ||
|
|
||
| <img src="https://cdn.rawgit.com/fantasyland/fantasy-land/master/figures/dependencies.svg" /> | ||
|
There was a problem hiding this comment. This is inadvisable:
The approach I used with Orthogonal was to add the SVG in one commit then reference its location by commit hash in the following commit. |
||
|
|
||
| ## General | ||
|
|
||
|
|
@@ -210,7 +210,7 @@ method takes one argument: | |
|
|
||
| 3. `ap` must apply the function in Apply `b` to the value in | ||
| Apply `a` | ||
|
|
||
| 1. No parts of return value of that function should be checked. | ||
|
|
||
| ### Applicative | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| digraph { | ||
| node [fontcolor=blue;shape=plaintext] | ||
|
There was a problem hiding this comment. Let's |
||
|
|
||
| # Algebras | ||
| Applicative [URL="#applicative"]; | ||
| Apply [URL="#apply"]; | ||
| Bifunctor [URL="#bifunctor"]; | ||
| Chain [URL="#chain"]; | ||
| ChainRec [URL="#chainrec"]; | ||
| Comonad [URL="#comonad"]; | ||
| Extend [URL="#extend"]; | ||
| Foldable [URL="#foldable"]; | ||
| Functor [URL="#functor"]; | ||
| Monad [URL="#monad"]; | ||
| Monoid [URL="#monoid"]; | ||
| Profunctor [URL="#profunctor"]; | ||
| Semigroup [URL="#semigroup"]; | ||
| Setoid [URL="#setoid"]; | ||
| Traversable [URL="#traversable"]; | ||
|
|
||
| # Dependencies | ||
| Applicative -> Monad; | ||
| Apply -> Applicative; | ||
| Apply -> Chain; | ||
| Chain -> ChainRec; | ||
| Chain -> Monad; | ||
| Extend -> Comonad; | ||
| Foldable -> Traversable; | ||
| Functor -> Apply; | ||
| Functor -> Bifunctor; | ||
| Functor -> Extend; | ||
| Functor -> Profunctor; | ||
| Functor -> Traversable; | ||
| Semigroup -> Monoid; | ||
| } | ||
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #!/bin/sh | ||
|
|
||
| dot -Tsvg -odependencies.svg dependencies.dot | ||
| dot -Tpng -odependencies.png dependencies.dot |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this list. It's duplicative now that the diagram is up to date. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's best to keep this. It's nice to have a fallback in case something happens with the image, different people process information differently, and it's still plaintext so it can be searched.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two points in favour of the ASCII version. 😜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
I'm fine with the output graph being ASCII. I just don't want to maintain the shape of the graph in raw ASCII.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm totally with you. A program like
dotwhich generates an ASCII diagram would be neat!I very much like your change. Thanks for taking the time to work on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does support multiple output formats, including
plain.plaingives you the size of the graph, a sequence of nodes with positions, and a sequence of edges with position if you want to parse the coordinates into an ascii thing. It looks like a regular language, so probably not too hard to parse.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! I may investigate that one day (but certainly not today).