Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: watcher ignores ts files in typescript projects #352

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

alemagio
Copy link
Contributor

Checklist

This patch was included as a comment here, it should be included in the template and be like that out of the box.

Without this change we have a weird behavior between the typescript watcher and the CLI watcher.
CLI watcher basically restart before the TS compiler finishes its job so the changes are not visible immediately.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. it can ensure fastify-cli only restart when the compiled code change.

@alemagio
Copy link
Contributor Author

LGTM. it can ensure fastify-cli only restart when the compiled code change.

Exactly

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch!

@mcollina mcollina merged commit ca72e80 into fastify:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants