Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PHP 8.4 implicit nullable deprecations #22

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

GromNaN
Copy link
Contributor

@GromNaN GromNaN commented Apr 29, 2024

Implicitly nullable parameters are deprecated in PHP 8.4.

This PR makes the nullable type explicit: https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

@GromNaN GromNaN changed the title Fix PHP 8.4 implicit nullable deprecations fix: PHP 8.4 implicit nullable deprecations Apr 29, 2024
@muglug muglug merged commit a9e113d into felixfbecker:master Apr 30, 2024
1 of 2 checks passed
@muglug
Copy link
Collaborator

muglug commented Apr 30, 2024

Thanks!

@GromNaN GromNaN deleted the php84-explicit-nullable branch April 30, 2024 07:54
@GromNaN
Copy link
Contributor Author

GromNaN commented Sep 18, 2024

Hello @muglug, could you release a bugfix version please. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants