Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose TCP echo on port 7 #16

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Expose TCP echo on port 7 #16

merged 1 commit into from
Jun 25, 2024

Conversation

rylev
Copy link
Collaborator

@rylev rylev commented Jun 24, 2024

Fixes #14

Uses port 7 in line with the echo protocol.

Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
@rylev rylev requested a review from lann June 24, 2024 11:44
@lann
Copy link

lann commented Jun 24, 2024

🦇

@rylev rylev merged commit c19e5cf into main Jun 25, 2024
2 checks passed
@rylev rylev deleted the tcp-echo-7 branch June 25, 2024 09:09
rylev added a commit to fermyon/spin that referenced this pull request Jun 28, 2024
fermyon/conformance-tests#16 changed the port
for the TCP echo service that these tests use and we did not change the
  port in these spin.toml files.
rylev added a commit to fermyon/spin that referenced this pull request Jun 28, 2024
fermyon/conformance-tests#16 changed the port
for the TCP echo service that these tests use and we did not change the
  port in these spin.toml files.

Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
me-diru pushed a commit to me-diru/spin that referenced this pull request Jul 9, 2024
fermyon/conformance-tests#16 changed the port
for the TCP echo service that these tests use and we did not change the
  port in these spin.toml files.

Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change tcp-echo service's exposed port
2 participants