Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): fix dispatch conditional #2434

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

vdice
Copy link
Member

@vdice vdice commented Apr 5, 2024

Apparently ${{ startsWith(github.ref, 'refs/tags/v') }} always resolves to true, presumably because when wrapped in expression brackets the result is a string rather than a boolean. Removing the expression brackets to fix... probably.

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
Copy link
Collaborator

@lann lann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops!

@vdice vdice enabled auto-merge April 5, 2024 20:46
@vdice vdice merged commit c01b28f into fermyon:main Apr 5, 2024
14 checks passed
@vdice vdice deleted the ci/fix-dispatch-logic branch April 5, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants