Bikeshed private endpoint UI #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd probably vote for |
rajatjindal
reviewed
Apr 15, 2024
crates/http/src/config.rs
Outdated
| /// Indicates that a trigger is a private endpoint (not routable). | ||
| #[derive(Clone, Debug, Default, Deserialize, Serialize)] | ||
| #[serde(deny_unknown_fields)] | ||
| pub struct HttpPriveteEndpoint { |
There was a problem hiding this comment.
nit: i think there is a typo here.
radu-matei
reviewed
Apr 15, 2024
crates/http/src/config.rs
Outdated
| @@ -18,7 +18,15 @@ pub struct HttpTriggerConfig { | |||
| #[serde(untagged)] | |||
| pub enum HttpTriggerRouteConfig { | |||
| Route(String), | |||
| IsRoutable(bool), | |||
| Private(HttpPriveteEndpoint), | |||
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
bikeshed-private-endpoints
branch
from
a5c1d60
to
95a548b
Compare
fibonacci1729
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per request from @ThorstenHans
I don't have a strong feeling one way or the other.